Replace ProjectNode::Expression with RowExpression step 1#12618
Closed
cemcayiroglu wants to merge 2 commits intoprestodb:masterfrom
Closed
Replace ProjectNode::Expression with RowExpression step 1#12618cemcayiroglu wants to merge 2 commits intoprestodb:masterfrom
cemcayiroglu wants to merge 2 commits intoprestodb:masterfrom
Conversation
cemcayiroglu
changed the title
cemcayiroglu
changed the title
highker
reviewed
Apr 11, 2019
| subPlan.getTranslations().put(inPredicate, inPredicateSubquerySymbol); | ||
|
|
||
| return appendApplyNode(subPlan, inPredicate, subqueryPlan.getRoot(), Assignments.of(inPredicateSubquerySymbol, inPredicateSubqueryExpression), correlationAllowed); | ||
| return appendApplyNode(subPlan, inPredicate, subqueryPlan.getRoot(), Assignments.of(inPredicateSubquerySymbol, castToRowExpression(inPredicateSubqueryExpression)), correlationAllowed); |
There was a problem hiding this comment.
Usually we do the cast at the very last step when replacing expressions. This will force us to build all the necessary infra for RowExpression then start a one-time migration. It would be cleaner and easier to revert.
|
superseded by #12747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.