Skip to content

[WIP] Function handle#12360

Closed
rongrong wants to merge 12 commits intoprestodb:masterfrom
rongrong:function-handle
Closed

[WIP] Function handle#12360
rongrong wants to merge 12 commits intoprestodb:masterfrom
rongrong:function-handle

Conversation

@rongrong
Copy link
Contributor

Introducing FuntionHandle based on trinodb/trino#196

@rongrong rongrong force-pushed the function-handle branch 6 times, most recently from 10931d3 to 25bf534 Compare February 23, 2019 01:22
@rongrong rongrong force-pushed the function-handle branch 7 times, most recently from 467fbca to 7de0ef2 Compare March 6, 2019 23:28
@rongrong rongrong requested a review from highker March 7, 2019 05:35
@highker
Copy link

highker commented Mar 7, 2019

@rongrong Is this still WIP or ready for review?

@rongrong
Copy link
Contributor Author

rongrong commented Mar 7, 2019

Let me create a new PR for review. I'll continue use this one for testing purpose. 😉

@rongrong rongrong force-pushed the function-handle branch 2 times, most recently from 1f00f27 to 220a175 Compare March 7, 2019 19:29
@rongrong rongrong force-pushed the function-handle branch 9 times, most recently from e1d3eb7 to 9fdb167 Compare March 13, 2019 05:56
lookupFunction would lookup up a function with a fully qualified name and fully bound types.
resolveFunction would resolve a function using the SQL path, and implicit type coercions.
Copy link

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be closed?

@rongrong rongrong closed this Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants