Merged
Conversation
yingsu00
force-pushed
the
revertLazyMap
branch
from
ecad1ef to
9cfa07c
Compare
Contributor
|
Please provide more info about why we are reverting these changes in the commit messages as they will be helpful later when we look at the git history. |
This reverts 1) commit ad05dcb. 2) commit 23de11f. PR prestodb#11791 (commit 23de11f and ad05dcb), which lazily builds the hashtables for maps, introduced a regression for the case where the MapBlock is created through AbstractMapBlock.getRegion(). The hashtables built on the MapBlock region were not updated in the original MapBlock, thus causing hashtables repeatedly being built on the same base MapBlock.
wenleix
approved these changes
Jan 8, 2019
Contributor
wenleix
left a comment
wenleix
left a comment
There was a problem hiding this comment.
LGTM.
Per discussion, please squash the two commit, and explain the reason of reverting in the commit message as well.
yingsu00
force-pushed
the
revertLazyMap
branch
from
9cfa07c to
1abaf91
Compare
martint
approved these changes
Jan 9, 2019
Contributor
martint
left a comment
martint
left a comment
There was a problem hiding this comment.
Assuming this is a pure revert with no additional changes, it looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #11791 (commit 23de11f), which lazily builds the hashtables for maps, introduced a regression for the case where the MapBlock is created through AbstractMapBlock.getRegion(). The hashtables built on the MapBlock region were not updated in the original MapBlock, thus causing hashtables repeatedly being built on the same base MapBlock.
The fix #12189 doesn't get time to get into release 0.216. So we will revert the original commit 23de11f and make the original commits and this fix in the next release 0.217