Fix lazy map hashtable regression#12164
Closed
yingsu00 wants to merge 1 commit intoprestodb:masterfrom
Closed
Conversation
yingsu00
force-pushed
the
lazyMapHTRegression
branch
from
f1c0c8b to
d9cb33b
Compare
Contributor
will the base MapBlock be updated to contain a full hash table or only for the entries for the slice/region? |
Contributor
Author
It would contain the full hash tables. |
yingsu00
force-pushed
the
lazyMapHTRegression
branch
2 times, most recently
from
5e9b998 to
4518407
Compare
yingsu00
force-pushed
the
lazyMapHTRegression
branch
from
4518407 to
f7f4792
Compare
yingsu00
changed the title
In 23de11f we lazily build the hashtables for map. It introduced a regression for the case where the MapBlock is created through AbstractMapBlock.getRegion(), in which the hashtables built on the MapBlock region was not updated in the original MapBlock, thus causing repeated hashtables build on the same base MapBlock. The change is to encapsulate the int[] hashtables in AbstractMapBlock$HashTables object and make it a member of MapBlock/MapBlockBuilder, so that when the sliced MapBlock builds the hashtables, the base MapBlock would also gets updated.
yingsu00
force-pushed
the
lazyMapHTRegression
branch
from
f7f4792 to
f95f61f
Compare
Contributor
|
@yingsu00 : Can you create an new PR for this so community can also look into this? -- Since previous emails might starts with Also, given we are already in release freeze, do we want to first revert it and get the fix in next version? |
Contributor
Author
|
Closing this in favor of new PR #12189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 23de11f we lazily build the hashtables for map. It introduced a
regression for the case where the MapBlock is created through
AbstractMapBlock.getRegion(), in which the hashtables built on the
MapBlock region was not updated in the original MapBlock, thus causing
repeated hashtables build on the same base MapBlock. The change is to
encapsulate the int[] hashtables in AbstractMapBlock$HashTables object
and make it a member of MapBlock/MapBlockBuilder, so that when the
sliced MapBlock builds the hashtables, the base MapBlock would also gets
updated.