Introduce Log function() conforming to SQL:2016#12127
Closed
Praveen2112 wants to merge 2 commits intoprestodb:masterfrom
Closed
Introduce Log function() conforming to SQL:2016#12127Praveen2112 wants to merge 2 commits intoprestodb:masterfrom
Praveen2112 wants to merge 2 commits intoprestodb:masterfrom
Conversation
Praveen2112
changed the title
Contributor
Author
Praveen2112
force-pushed
the
log_function
branch
from
21ea2a9 to
e7d2227
Compare
2 tasks
electrum
changed the title
electrum
reviewed
Dec 27, 2018
Contributor
There was a problem hiding this comment.
This no longer needs to be a class -- it can just be a function. Let's move it to be next to the other log functions.
Contributor
|
Let's change the second commit title to
The "with arguments swapped" is in reference to now-removed function and thus seems confusing. |
electrum
approved these changes
Dec 27, 2018
Praveen2112
force-pushed
the
log_function
branch
2 times, most recently
from
4de604e to
60e1523
Compare
Contributor
Author
|
@electrum Thanks for the review. Have implemented the above changes. |
Praveen2112
force-pushed
the
log_function
branch
from
60e1523 to
8ad7fbf
Compare
electrum
reviewed
Jan 1, 2019
Contributor
There was a problem hiding this comment.
This testLog test needs to be removed from the previous commit, otherwise it will fail as the log function no longer exists.
Praveen2112
force-pushed
the
log_function
branch
from
8ad7fbf to
0daf100
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the
logfunction with arguments swapped and also removes thedeprecated.legacy-log-functiontoggle.