Fix ARRAY_DISTINCT wrong results on NULL and 0#12103
Merged
yingsu00 merged 1 commit intoprestodb:masterfrom Dec 19, 2018
Merged
Fix ARRAY_DISTINCT wrong results on NULL and 0#12103yingsu00 merged 1 commit intoprestodb:masterfrom
yingsu00 merged 1 commit intoprestodb:masterfrom
Conversation
rongrong
reviewed
Dec 19, 2018
| assertFunction("ARRAY_DISTINCT(ARRAY [])", new ArrayType(UNKNOWN), ImmutableList.of()); | ||
|
|
||
| // Order matters here. Result should be stable. | ||
| assertFunction("ARRAY_DISTINCT(ARRAY [0, NULL])", new ArrayType(INTEGER), asList(0, (Object) null)); |
Contributor
There was a problem hiding this comment.
I don't think the (Object) is needed here, as well as in other newly added tests.
wenleix
reviewed
Dec 19, 2018
|
|
||
| if (array.getPositionCount() == 2) { | ||
| if (type.equalTo(array, 0, array, 1)) { | ||
| if (TypeUtils.positionEqualsPosition(type, array, 0, array, 1)) { |
Contributor
There was a problem hiding this comment.
I remember you mentioned we could use OperatorDependency to get the equal MethodHandle -- is that feasible?
I am just asking and this doesn't need to be done in this PR. -- we migrate the usage of positionEqualsPosition in a separate PR.
Contributor
Author
yingsu00
force-pushed
the
arraydistinct_fix
branch
from
891d46f to
507f0a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11977
Breaking #12080 into separate PRs. This PR is to fix ARRAY_DISTINCT only.