Closed
Conversation
Contributor
|
Is it possible to have test for that? |
electrum
approved these changes
Dec 18, 2018
Contributor
Author
kokosing
approved these changes
Dec 21, 2018
Contributor
There was a problem hiding this comment.
can you use try-with-resources for manager?
Contributor
Author
There was a problem hiding this comment.
No it doesn't implement AutoCloseable
dain
force-pushed
the
poll-nodes-on-workers
branch
4 times, most recently
from
f8aec11 to
4a0057c
Compare
Some connectors require an active list of all worers on worker nodes. This commit restores this behavior which was recently removed.
Instead of firing node change event each time nodes are polled, fire it only when the node set changes.
dain
force-pushed
the
poll-nodes-on-workers
branch
from
4a0057c to
c240f0d
Compare
Contributor
Author
kokosing
approved these changes
Jan 8, 2019
Contributor
kokosing
left a comment
kokosing
left a comment
There was a problem hiding this comment.
Can you also test that announcing same set of nodes (that were already announced) does not trigger any notification?
electrum
approved these changes
Jan 9, 2019
Contributor
|
Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some connectors require an active list of all worers on worker nodes. This
commit restores this behavior which was recently removed.