Add test for CBO decisions on TPC-H, TPC-DS queries

[kokosing]

Add test for CBO decisions on TPC-H, TPC-DS queries

[kokosing]

Applied comments from #11267

[kokosing]

In a follow up I would like to extract this concept and use it (replace the usage) instead of com.facebook.presto.sql.planner.assertions.PlanMatchPattern. This is much more easier to debug and maintain.

[kokosing]

cc: @atris

[arhimondr]

Some comments

[arhimondr]

I think this readme file should remain in presto-benchto-benchmarks

[arhimondr]

presto-benchto-queries

[arhimondr]

Move it to the previous commit

[arhimondr]

Move it to the previous commit

[arhimondr]

Move it to the previous commit

[arhimondr]

You don't need this. Use Resources.toString()

[arhimondr]

Ditto. Use Resources

[arhimondr]

Scan queries in the classpath instead.

Reflections reflections = new Reflections("some.package", new ResourcesScanner());
Set<String> fileNames = reflections.getResources(Pattern.compile("q(\\d+)\.sql"));

[kokosing]

I would prefer not to drag new dependency just for this

[arhimondr]

Sorry, i thought this is the class from Guava. Nevermind than.

[arhimondr]

Extract ID from query file Pattern.compile("q(\\d+)\.sql")

[arhimondr]

Scan resources from the resource path, so you don't need to do this hack

[kokosing]

Comments applied.

[arhimondr]

LGTM % few comments

[arhimondr]

Make it String. Path object implies a reference to a real file system.

[arhimondr]

How about

private String getQueryPlanResourcePath(String queryResourcePath)
    {
        return queryResourcePath.replace("\.sql$", ".plan");
    }

[arhimondr]

static import

[arhimondr]

static import

[arhimondr]

static import getResource. Also you can use getResource(string). Context class loader should be fine here.

[kokosing]

Context class loader should be fine here.

It does not work.

[arhimondr]

Move it before the JoinOrderPrinter. Class definition come last.

[kokosing]

Comments addressed. Thanks!

[kokosing]

Context class loader should be fine here.

It does not work.

[findepi]

Was it an intentional change that i can no longer just run TestTpcdsCostBasedPlan$UpdateTestFiles?

Exception in thread "main" java.lang.IllegalStateException: java.lang.IllegalStateException: This class must be executed from presto-main or presto source directory
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:593)
	at java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:677)
	at java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:735)
	at java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:160)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:174)
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
	at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
	at com.facebook.presto.sql.planner.optimizations.AbstractCostBasedPlanTest.generate(AbstractCostBasedPlanTest.java:90)
	at com.facebook.presto.sql.planner.optimizations.TestTpcdsCostBasedPlan$UpdateTestFiles.main(TestTpcdsCostBasedPlan.java:91)
Caused by: java.lang.IllegalStateException: This class must be executed from presto-main or presto source directory
	at com.facebook.presto.sql.planner.optimizations.AbstractCostBasedPlanTest.getPrestoMainSourcePath(AbstractCostBasedPlanTest.java:143)
	at com.facebook.presto.sql.planner.optimizations.AbstractCostBasedPlanTest.lambda$generate$0(AbstractCostBasedPlanTest.java:93)
...

[findepi]

Also, the exception is misleading. IntelliJ was setting presto source dir as working directory by default.