Skip to content

Report error when partition schema and parquet file schema mismatch #11515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qqibrow wants to merge 1 commit into from
Closed

Report error when partition schema and parquet file schema mismatch #11515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions presto-hive/src/main/java/com/facebook/presto/hive/parquet/HdfsParquetDataSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ public HdfsParquetDataSource(Path path, long size, FSDataInputStream inputStream
this.stats = stats;
}

@Override
public String getPath()
{
return name;
}

@Override
public final long getReadBytes()
{
Expand Down
2 changes: 2 additions & 0 deletions presto-parquet/src/main/java/com/facebook/presto/parquet/ParquetDataSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
public interface ParquetDataSource
extends Closeable
{
String getPath();

long getReadBytes();

long getSize();
Expand Down
16 changes: 15 additions & 1 deletion presto-parquet/src/main/java/com/facebook/presto/parquet/reader/ParquetReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import com.facebook.presto.spi.type.MapType;
import com.facebook.presto.spi.type.Type;
import com.facebook.presto.spi.type.TypeSignatureParameter;
import com.google.common.base.Joiner;
import it.unimi.dsi.fastutil.booleans.BooleanArrayList;
import it.unimi.dsi.fastutil.booleans.BooleanList;
import it.unimi.dsi.fastutil.ints.IntArrayList;
Expand All @@ -53,6 +54,8 @@
import static com.google.common.base.Preconditions.checkArgument;
import static java.lang.Math.min;
import static java.lang.Math.toIntExact;
import static java.lang.String.format;
import static java.util.Locale.ENGLISH;
import static java.util.Objects.requireNonNull;

public class ParquetReader
Expand Down Expand Up @@ -206,7 +209,18 @@ private ColumnChunk readPrimitive(PrimitiveField field)
ParquetColumnChunk columnChunk = new ParquetColumnChunk(descriptor, buffer, 0);
columnReader.setPageReader(columnChunk.readAllPages());
}
return columnReader.readPrimitive(field);
try {
return columnReader.readPrimitive(field);
}
catch (UnsupportedOperationException e) {
Copy link
Copy Markdown
Contributor

@nezihyigitbasi nezihyigitbasi Dec 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of relying on the UnsupportedOperationException thrown by the Type classes, it may be cleaner to throw a specific exception (e.g., ParquetSchemaMismatchException or sth like that) in PrimitiveColumnReader::readValue(). What do you think?

throw new ParquetCorruptionException(format(
Copy link
Copy Markdown
Contributor

@nezihyigitbasi nezihyigitbasi Dec 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really a corruption issue. Sometimes users just alter their tables and hit this issue as well.

"There is a mismatch between parquet file schema and partition schema. " +
"The column %s in file %s is declared as type %s but parquet file declared column type as %s.",
Joiner.on(".").join(columnDescriptor.getPath()).toLowerCase(ENGLISH),
dataSource.getPath(),
field.getType(),
columnDescriptor.getType()));
}
}

private byte[] allocateBlock(int length)
Expand Down