Collect data size statistic #11185
Merged
arhimondr merged 0 commit intoprestodb:masterfrom Aug 6, 2018
Merged
Conversation
rschlussel
reviewed
Aug 3, 2018
Contributor
There was a problem hiding this comment.
should be only non-null rows
Contributor
There was a problem hiding this comment.
averageColumnLength only includes non-null rows.
electrum
approved these changes
Aug 3, 2018
Contributor
There was a problem hiding this comment.
This name sounds strange, how about TOTAL_SIZE_IN_BYTES
Contributor
There was a problem hiding this comment.
Similar to the enum, let's drop the values part and call this totalSizeInBytes everywhere?
Contributor
There was a problem hiding this comment.
As a separate refactor, it might be nice to introduce a constant for the name:
@AggregationFunction(value = SumDataSizeForStats.NAME, hidden = true)
public final class SumDataSizeForStats
{
public static final String NAME = "$internal$sum_data_size_for_stats";
...
arhimondr
force-pushed
the
collect-colunm-data-size
branch
from
c5af79f to
51a1064
Compare
Member
Author
|
@electrum @rschlussel Comments addressed |
rschlussel
approved these changes
Aug 6, 2018
Contributor
rschlussel
left a comment
rschlussel
left a comment
There was a problem hiding this comment.
Check the travis build. The failure looks related.
arhimondr
force-pushed
the
collect-colunm-data-size
branch
from
51a1064 to
35b77b3
Compare
arhimondr
force-pushed
the
collect-colunm-data-size
branch
from
35b77b3 to
9b31a8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Hive connector for CHAR, VARCHAR, VARBINARY columns.