Skip to content

Pull dataSize statistics from Hive for VARCHAR columns #11107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
findepi wants to merge 15 commits into from
Closed

Pull dataSize statistics from Hive for VARCHAR columns #11107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
785d166
Fix assertion messages in Tpch, Tpcds stat tests
findepi Mar 26, 2018
6a2a56e
Extract variable
findepi Mar 26, 2018
d779df0
Fix NATION_PARTITIONED_BY_REGIONKEY data files
losipiuk Mar 26, 2018
f1b8102
Remove unnecessary condition
findepi Mar 26, 2018
a72a4a9
Check value is known as early as possible
findepi Mar 26, 2018
142735b
Remove redundant else
findepi Mar 26, 2018
038ddaf
Rename parameter to match meaning
findepi Mar 26, 2018
6ed8592
Extract rowsPerPartition calculation
findepi Mar 26, 2018
71ba5f1
Pull dataSize statistics from Hive for VARCHAR columns
losipiuk Mar 26, 2018
23bedcd
Inline StatisticsEstimator#addPartitionStats's overload
findepi Mar 26, 2018
c305d90
Update TPC-H statistics with data size
losipiuk Mar 26, 2018
0a53b74
Update TPC-DS statistics with data size
losipiuk Mar 26, 2018
f653640
Add statistics test for table partitioned by varchar column
losipiuk Mar 26, 2018
53652b7
fixup! Pull dataSize statistics from Hive for VARCHAR columns
findepi Jul 26, 2018
e201f45
fixup! Pull dataSize statistics from Hive for VARCHAR columns
findepi Jul 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
214 changes: 157 additions & 57 deletions ...ve/src/main/java/com/facebook/presto/hive/statistics/MetastoreHiveStatisticsProvider.java
View file
Open in desktop

Large diffs are not rendered by default.

15 changes: 15 additions & 0 deletions presto-hive/src/test/java/com/facebook/presto/hive/AbstractTestHiveClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,7 +1321,11 @@ private void assertTableStatsComputed(

assertEquals(columnsStatistics.keySet(), expectedColumnStatsColumns, "columns with statistics");

Map<String, ColumnHandle> columnHandles = metadata.getColumnHandles(session, tableHandle);
Copy link
Copy Markdown
Member

@arhimondr arhimondr Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you can make it to be Map<String, Type> columnTypes to make it even nicer

columnsStatistics.forEach((columnName, columnStatistics) -> {
ColumnHandle columnHandle = columnHandles.get(columnName);
Type columnType = metadata.getColumnMetadata(session, tableHandle, columnHandle).getType();

assertFalse(
columnStatistics.getNullsFraction().isValueUnknown(),
"unknown nulls fraction for " + columnName);
Expand All @@ -1333,6 +1337,17 @@ private void assertTableStatsComputed(
assertFalse(
rangeColumnStatistics.getFraction().isValueUnknown(),
"unknown range non-null fraction for " + columnName);

if (isVarcharType(columnType)) {
assertFalse(
rangeColumnStatistics.getDataSize().isValueUnknown(),
"unknown range data size for " + columnName);
}
else {
assertTrue(
rangeColumnStatistics.getDataSize().isValueUnknown(),
"known range data size for" + columnName);
}
});
}
}
Expand Down
42 changes: 36 additions & 6 deletions presto-product-tests/src/main/java/com/facebook/presto/tests/hive/HiveTableDefinitions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import io.prestodb.tempto.fulfillment.table.hive.HiveTableDefinition;

import static io.prestodb.tempto.fulfillment.table.hive.InlineDataSource.createResourceDataSource;
import static java.lang.String.format;

public class HiveTableDefinitions
{
Expand All @@ -25,7 +26,7 @@ public class HiveTableDefinitions

public static final int NATION_PARTITIONED_BY_REGIONKEY_NUMBER_OF_LINES_PER_SPLIT = 5;

public static final HiveTableDefinition NATION_PARTITIONED_BY_REGIONKEY =
public static final HiveTableDefinition NATION_PARTITIONED_BY_BIGINT_REGIONKEY =
HiveTableDefinition.builder(NATION_PARTITIONED_BY_REGIONKEY_TABLE_NAME)
.setCreateTableDDLTemplate(
"CREATE %EXTERNAL% TABLE %NAME%(" +
Expand All @@ -39,24 +40,53 @@ public class HiveTableDefinitions
createResourceDataSource(
NATION_PARTITIONED_BY_REGIONKEY_TABLE_NAME,
DATA_REVISION,
partitionDataFileResource(1)))
partitionDataFileResource("bigint", "1")))
.addPartition(
"p_regionkey=2",
createResourceDataSource(
NATION_PARTITIONED_BY_REGIONKEY_TABLE_NAME,
DATA_REVISION,
partitionDataFileResource(2)))
partitionDataFileResource("bigint", "2")))
.addPartition(
"p_regionkey=3",
createResourceDataSource(
NATION_PARTITIONED_BY_REGIONKEY_TABLE_NAME,
DATA_REVISION,
partitionDataFileResource(3)))
partitionDataFileResource("bigint", "3")))
.build();

private static String partitionDataFileResource(int region)
public static final HiveTableDefinition NATION_PARTITIONED_BY_VARCHAR_REGIONKEY =
HiveTableDefinition.builder(NATION_PARTITIONED_BY_REGIONKEY_TABLE_NAME)
.setCreateTableDDLTemplate(
"CREATE %EXTERNAL% TABLE %NAME%(" +
" p_nationkey BIGINT," +
" p_name VARCHAR(25)," +
" p_comment VARCHAR(152)) " +
"PARTITIONED BY (p_regionkey VARCHAR(20))" +
"ROW FORMAT DELIMITED FIELDS TERMINATED BY '|' ")
.addPartition(
"p_regionkey='AMERICA'",
createResourceDataSource(
NATION_PARTITIONED_BY_REGIONKEY_TABLE_NAME,
DATA_REVISION,
partitionDataFileResource("varchar", "america")))
.addPartition(
"p_regionkey='ASIA'",
createResourceDataSource(
NATION_PARTITIONED_BY_REGIONKEY_TABLE_NAME,
DATA_REVISION,
partitionDataFileResource("varchar", "asia")))
.addPartition(
"p_regionkey='EUROPE'",
createResourceDataSource(
NATION_PARTITIONED_BY_REGIONKEY_TABLE_NAME,
DATA_REVISION,
partitionDataFileResource("varchar", "europe")))
.build();

private static String partitionDataFileResource(String key, String partition)
{
return "com/facebook/presto/tests/hive/data/partitioned_nation/nation_region_" + region + ".textfile";
return format("com/facebook/presto/tests/hive/data/partitioned_nation_%s/nation_region_%s.textfile", key, partition);
}

private HiveTableDefinitions()
Expand Down
6 changes: 3 additions & 3 deletions presto-product-tests/src/main/java/com/facebook/presto/tests/hive/TestExternalHiveTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import org.testng.annotations.Test;

import static com.facebook.presto.tests.TestGroups.HIVE_CONNECTOR;
import static com.facebook.presto.tests.hive.HiveTableDefinitions.NATION_PARTITIONED_BY_REGIONKEY;
import static com.facebook.presto.tests.hive.HiveTableDefinitions.NATION_PARTITIONED_BY_BIGINT_REGIONKEY;
import static com.facebook.presto.tests.hive.HiveTableDefinitions.NATION_PARTITIONED_BY_REGIONKEY_NUMBER_OF_LINES_PER_SPLIT;
import static com.facebook.presto.tests.utils.QueryExecutors.onHive;
import static com.facebook.presto.tests.utils.QueryExecutors.onPresto;
Expand All @@ -41,7 +41,7 @@ public Requirement getRequirements(Configuration configuration)
{
return compose(
mutableTable(NATION),
mutableTable(NATION_PARTITIONED_BY_REGIONKEY));
mutableTable(NATION_PARTITIONED_BY_BIGINT_REGIONKEY));
}

@Test(groups = {HIVE_CONNECTOR})
Expand All @@ -68,7 +68,7 @@ public void testDeleteFromExternalTable()
@Test(groups = {HIVE_CONNECTOR})
public void testDeleteFromExternalPartitionedTableTable()
{
TableInstance nation = mutableTablesState().get(NATION_PARTITIONED_BY_REGIONKEY.getName());
TableInstance nation = mutableTablesState().get(NATION_PARTITIONED_BY_BIGINT_REGIONKEY.getName());
onHive().executeQuery("DROP TABLE IF EXISTS " + EXTERNAL_TABLE_NAME);
onHive().executeQuery("CREATE EXTERNAL TABLE " + EXTERNAL_TABLE_NAME + " LIKE " + nation.getNameInDatabase() + " LOCATION '/tmp/" + EXTERNAL_TABLE_NAME + "_" + nation.getNameInDatabase() + "'");
insertNationPartition(nation, 1);
Expand Down
Loading