Fix backward-compatibility processing for array with one group field#10852
Merged
nezihyigitbasi merged 1 commit intoprestodb:masterfrom Jun 18, 2018
Merged
Conversation
According to Parquet spec: If the repeated field is a group with one field and is named either array or uses the LIST-annotated group's name with _tuple appended then the repeated type is the element type and elements are required. https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists
Collaborator
|
nice fix, looks good to me |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Parquet spec:
If the repeated field is a group with one field and is named either array
or uses the LIST-annotated group's name with _tuple appended
then the repeated type is the element type and elements are required.
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists