Skip to content

Fix New Parquet Reader reading array<struct<type:string>> #10849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhenxiao wants to merge 1 commit into from
Closed

Fix New Parquet Reader reading array<struct<type:string>> #10849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions presto-hive/src/main/java/parquet/io/ColumnIOConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,13 @@ public static Optional<Field> constructField(Type type, ColumnIO columnIO)
int repetitionLevel = columnIO.getRepetitionLevel();
int definitionLevel = columnIO.getDefinitionLevel();
if (ROW.equals(type.getTypeSignature().getBase())) {
if (columnIO instanceof PrimitiveColumnIO) {
// single element struct
PrimitiveColumnIO primitiveColumnIO = (PrimitiveColumnIO) columnIO;
RichColumnDescriptor column = new RichColumnDescriptor(primitiveColumnIO.getColumnDescriptor(), columnIO.getType().asPrimitiveType());
Optional<Field> field = Optional.of(new PrimitiveField(type.getTypeParameters().get(0), repetitionLevel, definitionLevel, required, column, primitiveColumnIO.getId()));
return Optional.of(new GroupField(type, repetitionLevel, definitionLevel, required, ImmutableList.of(field)));
}
GroupColumnIO groupColumnIO = (GroupColumnIO) columnIO;
List<Type> parameters = type.getTypeParameters();
ImmutableList.Builder<Optional<Field>> fileldsBuilder = ImmutableList.builder();
Expand Down
13 changes: 13 additions & 0 deletions presto-hive/src/test/java/com/facebook/presto/hive/parquet/AbstractTestParquetReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,19 @@ public void testArrayOfStructs()
values, values, new ArrayType(structType));
}

@Test
public void testArrayOfStructOfSingleElement()
throws Exception
{
Iterable<List> structs = createNullableTestStructs(transform(intsBetween(0, 31_234), Object::toString));
Iterable<List<List>> values = createTestArrays(structs);
List<String> structFieldNames = asList("stringField");
Type structType = RowType.from(asList(field("stringField", VARCHAR)));
tester.testRoundTrip(
getStandardListObjectInspector(getStandardStructObjectInspector(structFieldNames, asList(javaStringObjectInspector))),
values, values, new ArrayType(structType));
}

@Test
public void testCustomSchemaArrayOfStucts()
throws Exception
Expand Down