Minimal presto-pinot driver exposing just pinot-common and some helper#1
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
wenleix
reviewed
Oct 21, 2019
highker
reviewed
Oct 21, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
The shading looks great. Minor comments on coding style
Author
|
I think I have addressed all of the code review comments now and am looking forward to seeing this approved and a version 0.1.0 of this jar released to mavencentral such that I can unblock prestodb/presto#13504. Thank you ! |
highker
approved these changes
Oct 22, 2019
| } | ||
| } | ||
|
|
||
| private static class ScatterGatherRequestImpl |
There was a problem hiding this comment.
Could you address this comment as well?
| return dataTableMap; | ||
| } | ||
|
|
||
| private CompositeFuture<byte[]> routeScatterGather(ScatterGatherRequestImpl scatterRequest, ScatterGatherStats scatterGatherStats) |
There was a problem hiding this comment.
Could you address this comment as well?
| @Override | ||
| public byte[] getRequestForService(List<String> segments) | ||
| { | ||
| InstanceRequest r = new InstanceRequest(); |
There was a problem hiding this comment.
Could you address this comment as well?
This is so that the accompanying presto-pinot connector in prestodb/presto proper has simpler dependencies. This is in line with the approach taken by other heavy weight connectors like presto-kudu and presto-cassandra. The basic approach is that the stuff in pinot-common is exposed out as is and the rest are shaded, since this is the public api. Also added a class taken from the Pinot broker to federate a PQL to bunch of servers. The helper class PinotScatterGatherQueryClient does the job of the pinot to send the query to a pinot server via the internal thrift protocol. TODO: Couldn't figure out what to do with the logging classes. Currently they aren't exposed out but what happens if this library need to do some logging ?
|
@wenleix, could you help doing a release? THANKS! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so that the accompanying presto-pinot connector in
prestodb/presto proper has simpler dependencies.
This is in line with the approach taken by other heavy weight connectors
like presto-kudu and presto-cassandra.
The basic approach is that the stuff in pinot-common is exposed out as
is and the rest are shaded, since this is the public api. Also added a
class taken from the Pinot broker to federate a PQL to bunch of servers.
The helper class PinotScatterGatherQueryClient does the job of the pinot
to send the query to a pinot server via the internal thrift protocol.
TODO: Couldn't figure out what to do with the logging classes. Currently
they aren't exposed out but what happens if this library need to do some
logging ?