Skip to content

Fix for issue https://github.com/prestodb/presto-maven-plugin/issues/1 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanglinsong merged 1 commit into from
Feb 22, 2023
Merged

Fix for issue https://github.com/prestodb/presto-maven-plugin/issues/1 #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/facebook/presto/maven/ServiceDescriptorGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ private List<Class<?>> findImplementationsOf(Class<?> implementationTemplate, UR
List<Class<?>> implementations = Lists.newArrayList();
List<String> classes = FileUtils.getFileNames(classesDirectory, "**/*.class", null, false);
for (String classPath : classes) {
String className = classPath.substring(0, classPath.length() - 6).replace('/', '.');
String className = classPath.substring(0, classPath.length() - 6).replace(File.separatorChar, '.');
Copy link
Copy Markdown
Member

@wanglinsong wanglinsong Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaceAll?

Copy link
Copy Markdown

@dnskr dnskr Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wanglinsong No, replace should be used, because it replaces all occurrences:

public String replace(char oldChar, char newChar)
Returns a string resulting from replacing all occurrences of oldChar in this string with newChar.

while replaceAll works with regular expressions.

But I agree that it's confusing naming.

try {
Class<?> implementation = searchRealm.loadClass(implementationTemplate.getName());
Class<?> clazz = searchRealm.loadClass(className);
Expand Down