Skip to content

Fix for CVE-2024-36124 . Upgrading snappy version to 0.5. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdcmeehan merged 1 commit into from
Jan 21, 2025
Merged

Fix for CVE-2024-36124 . Upgrading snappy version to 0.5. #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
<dependency>
<groupId>org.iq80.snappy</groupId>
<artifactId>snappy</artifactId>
<version>0.2</version>
<version>0.5</version>
Copy link
Copy Markdown
Member

@agrawalreetika agrawalreetika Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@namya28 I see 0.5 also has CVEs? https://mvnrepository.com/artifact/org.iq80.snappy/snappy/0.5

Copy link
Copy Markdown
Member

@imjalpreet imjalpreet Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all the vulnerabilities are in the dependency snappy-java (https://mvnrepository.com/artifact/org.xerial.snappy/snappy-java/1.1.8.4) with test scope, so they won't be included in the snappy jar Presto is using. We should be fine.

Copy link
Copy Markdown
Member

@agrawalreetika agrawalreetika Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then in the existing version as well it looks to me in test dependencies only. Anything I am missing here?
https://mvnrepository.com/artifact/org.iq80.snappy/snappy/0.2

Copy link
Copy Markdown
Member

@agrawalreetika agrawalreetika Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nut looks like on top it mentions until 0.4 there is one direct CVE - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-36124
Which doesn't seem to appear in - 0.5

Copy link
Copy Markdown
Member

@imjalpreet imjalpreet Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, <=0.4 had a direct vulnerability in Snappy not coming from any dependencies in addition to the vulnerabilities coming from test dependencies.

</dependency>

<dependency>
Expand Down