Skip to content

Fix NoClassDefFoundError for JsonNode#49

Merged
beinan merged 1 commit intoprestodb:masterfrom
shangxinli:master
Aug 12, 2021
Merged

Fix NoClassDefFoundError for JsonNode#49
beinan merged 1 commit intoprestodb:masterfrom
shangxinli:master

Conversation

@shangxinli
Copy link
Contributor

When rolling out hive-apache-3.0.0-5 to Presto (PR), here are error message:

java.lang.NoClassDefFoundError: com/facebook/presto/hive/$internal/org/codehaus/jackson/JsonNode
presto-worker_1 | at org.apache.hadoop.hive.serde2.avro.AvroSerDe.getSchemaFromCols(AvroSerDe.java:178)

After investigation, it turned out we need to make this change to solve that.

@shangxinli
Copy link
Contributor Author

@beinan Do you have time to review it?

@vivek-bharathan
Copy link

@tdcmeehan - Could you please help with this?

Copy link
Member

@beinan beinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, many thanks for fixing this one!

@beinan
Copy link
Member

beinan commented Aug 11, 2021

@tdcmeehan do you wanna take a look of this one? or I would merge it.

@shangxinli
Copy link
Contributor Author

Thanks @beinan

@beinan beinan merged commit 069602c into prestodb:master Aug 12, 2021
@beinan
Copy link
Member

beinan commented Aug 12, 2021

Thank you both! Merging it!

@shangxinli
Copy link
Contributor Author

@beinan @tdcmeehan Can we have a release so that we can use it in Presto?

@beinan
Copy link
Member

beinan commented Aug 18, 2021

@shangxinli I can help to prepare the release branch and tag, but I need help from facebook team to upload the artifact to maven repo. @tdcmeehan @aweisberg could you help? Thanks!

@aweisberg
Copy link
Contributor

If you run release-prepare I can build and release to maven https://maven.apache.org/maven-release/maven-release-plugin/examples/prepare-release.html

@beinan
Copy link
Member

beinan commented Aug 19, 2021

Thank you @aweisberg ! just finished the release-prepare. tag: https://github.com/prestodb/presto-hive-apache/tree/3.0.0-6

In case you might need ❯ cat release.properties

#release configuration
#Thu Aug 19 11:08:14 PDT 2021
scm.tagNameFormat=@{project.version}
project.scm.com.facebook.presto.hive\:hive-apache.connection=scm\:git\:git\://github.com/prestodb/presto-hive-apache.git
scm.tag=3.0.0-6
pushChanges=false
scm.url=scm\:git\:git\://github.com/prestodb/presto-hive-apache.git
preparationGoals=clean install
project.scm.com.facebook.presto.hive\:hive-apache.tag=HEAD
project.scm.com.facebook.presto.hive\:hive-apache.url=https\://github.com/prestodb/presto-hive-apache
project.scm.com.facebook.presto.hive\:hive-apache.developerConnection=scm\:git\:git\://github.com/prestodb/presto-hive-apache.git
remoteTagging=true
scm.commentPrefix=[maven-release-plugin]
project.dev.com.facebook.presto.hive\:hive-apache=3.0.0-7-SNAPSHOT
project.rel.com.facebook.presto.hive\:hive-apache=3.0.0-6
exec.snapshotReleasePluginAllowed=false
completedPhase=end-release

@aweisberg
Copy link
Contributor

Thanks for the release.properties. It's released now.

@shangxinli
Copy link
Contributor Author

@beinan @aweisberg @tdcmeehan Thank you so much! I will have a try on 3.0.6 in Presto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants