Fix NoClassDefFoundError for JsonNode#49
Conversation
|
@beinan Do you have time to review it? |
|
@tdcmeehan - Could you please help with this? |
beinan
left a comment
There was a problem hiding this comment.
lgtm, many thanks for fixing this one!
|
@tdcmeehan do you wanna take a look of this one? or I would merge it. |
|
Thanks @beinan |
|
Thank you both! Merging it! |
|
@beinan @tdcmeehan Can we have a release so that we can use it in Presto? |
|
@shangxinli I can help to prepare the release branch and tag, but I need help from facebook team to upload the artifact to maven repo. @tdcmeehan @aweisberg could you help? Thanks! |
|
If you run release-prepare I can build and release to maven https://maven.apache.org/maven-release/maven-release-plugin/examples/prepare-release.html |
|
Thank you @aweisberg ! just finished the release-prepare. tag: https://github.com/prestodb/presto-hive-apache/tree/3.0.0-6 In case you might need ❯ cat release.properties |
|
Thanks for the release.properties. It's released now. |
|
@beinan @aweisberg @tdcmeehan Thank you so much! I will have a try on 3.0.6 in Presto. |
When rolling out hive-apache-3.0.0-5 to Presto (PR), here are error message:
java.lang.NoClassDefFoundError: com/facebook/presto/hive/$internal/org/codehaus/jackson/JsonNode
presto-worker_1 | at org.apache.hadoop.hive.serde2.avro.AvroSerDe.getSchemaFromCols(AvroSerDe.java:178)
After investigation, it turned out we need to make this change to solve that.