Skip to content

feat(server): Add a KeyStoreScanner#133

Closed
aaneja wants to merge 1 commit intoprestodb:masterfrom
aaneja:keyStoreScanner
Closed

feat(server): Add a KeyStoreScanner#133
aaneja wants to merge 1 commit intoprestodb:masterfrom
aaneja:keyStoreScanner

Conversation

@aaneja
Copy link
Copy Markdown

@aaneja aaneja commented Nov 13, 2025

To allow for hot reloading the tls keystore

See for more details : https://jetty.org/docs/jetty/12.1/programming-guide/server/http.html#connector-protocol-tls-keystore-auto-reload

Testing

WIP : Will test this locally and paste results
TODO : Add a new test for this in TestHttpServerProvider, similar to an existing one

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Nov 13, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR integrates a KeyStoreScanner into the HttpServer setup to poll and reload the TLS keystore automatically (every 1s by default) by instantiating it with the existing SSLContextFactory and registering it as a Jetty bean.

Sequence diagram for TLS keystore auto-reload process

sequenceDiagram
    participant KeyStoreScanner
    participant SSLContextFactory
    loop Every 1s
        KeyStoreScanner->>SSLContextFactory: check for keystore changes
        alt If keystore changed
            KeyStoreScanner->>SSLContextFactory: reload()
        end
    end
Loading

Class diagram for KeyStoreScanner integration in HttpServer

classDiagram
    class HttpServer {
        +HttpServerInfo httpServerInfo
        +Server server
        +SSLContextFactory sslContextFactory
        +KeyStoreScanner keyStoreScanner
    }
    class KeyStoreScanner {
        +KeyStoreScanner(SSLContextFactory sslContextFactory)
        +scanInterval: int
        +start()
        +stop()
    }
    class SSLContextFactory {
        +reload()
    }
    HttpServer --> KeyStoreScanner : adds bean
    KeyStoreScanner --> SSLContextFactory : monitors
Loading

File-Level Changes

Change Details Files
Introduce KeyStoreScanner to enable hot-reloading of TLS keystore
  • Instantiate KeyStoreScanner with the existing sslContextFactory
  • Add the scanner to the server via server.addBean(keyStoreScanner)
  • Document the default 1s scan interval and note future configurability
http-server/src/main/java/com/facebook/airlift/http/server/HttpServer.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@aaneja
Copy link
Copy Markdown
Author

aaneja commented Nov 21, 2025

Closing in favor of #134

@aaneja aaneja closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant