fix: catalog upgrade/downgrade (apache#29780)

superset/db_engine_specs/base.py

@@ -92,6 +92,12 @@
 
 logger = logging.getLogger()
 
+# When connecting to a database it's hard to catch specific exceptions, since we support
+# more than 50 different database drivers. Usually the try/except block will catch the
+# generic `Exception` class, which requires a pylint disablee comment. To make it clear
+# that we know this is a necessary evil we create an alias, and catch it instead.
+GenericDBException = Exception
+
 
 def convert_inspector_columns(cols: list[SQLAColumnType]) -> list[ResultSetColumnType]:
     result_set_columns: list[ResultSetColumnType] = []
@@ -406,7 +412,8 @@ class BaseEngineSpec:  # pylint: disable=too-many-public-methods
     #
     # When this is changed to true in a DB engine spec it MUST support the
     # `get_default_catalog` and `get_catalog_names` methods. In addition, you MUST write
-    # a database migration updating any existing schema permissions.
+    # a database migration updating any existing schema permissions using the helper
+    # `upgrade_catalog_perms`.
     supports_catalog = False
 
     # Can the catalog be changed on a per-query basis?

superset/db_engine_specs/databricks.py

@@ -434,8 +434,8 @@ def get_default_catalog(
         cls,
         database: Database,
     ) -> str | None:
-        with database.get_inspector() as inspector:
-            return inspector.bind.execute("SELECT current_catalog()").scalar()
+        with database.get_sqla_engine() as engine:
+            return engine.execute("SELECT current_catalog()").scalar()
 
     @classmethod
     def get_prequeries(