A simple way to implement tagbar async call #561
Conversation
There was a problem hiding this comment.
Thanks for taking the time to contribute @pangchol. I've made a few notes of things that will need refactoring before this can be included. There might be more, but starting with those should make it a lot easier to review what is left. Note also the comment message should be en English, and don't forget to run the liter as that will be required. You can see the output here from the PR or run it locally yourself with vint .. Thanks!
| let g:tagbar_update_fname = a:fname | ||
| let g:tagbar_update_force = a:force | ||
| let g:tagbar_no_display = a:0 > 0 ? a:1 : 0 | ||
| if has('win32') " windows use timer_start will call bug |
There was a problem hiding this comment.
Where is this bug documented upstream (so we can track when to revert workarounds)
| let no_display = a:0 > 0 ? a:1 : 0 | ||
| function! AutoUpdate_CB(channel, ...) abort | ||
| " call tagbar#debug#log('AutoUpdate called [' . fname . ']') | ||
| let l:fname = g:tagbar_update_fname |
There was a problem hiding this comment.
Why are you passing global variables around here? This seems to rely on side effects, this function should be refactored to accept all the arguments it will use (as in the function it is replacing).
There was a problem hiding this comment.
The use of global variables is because I don't know how to pass parameters in a callback , so I'm just using global variables for simple pass paramenters.
There was a problem hiding this comment.
We're going to have to figure out how to do that, or at least some other mechanism which will protect them from being clobbered. As soon as asynchronous jobs start getting involved it's really easy to introduce bugs if you are relying on side effects. I don't want to start down that road here.
There was a problem hiding this comment.
It looks like you can pass a function reference, so something like:
call timer_start(1, function('AutoUpdato_CB', [a:jobid], fname))But you'll have to play around with specifics. The async.vim code might give you some clues.
There was a problem hiding this comment.
so after some experimentation, the timer_start() routine operates in the same thread context. So this would only delay the processing of ctags, and any apparent 'lockup' effect of vim during ctags processing will still occur, only a little bit after once the timer pops.
Closes #532.