Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modification of menu keybindings #923

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

Leandros
Copy link
Contributor

My keyboard layout has different keys on 'j' & 'k'. This allows changing the defaults.

Copy link
Member

@PhilRunninger PhilRunninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/nerdtree/menu_controller.vim Outdated Show resolved Hide resolved
lib/nerdtree/menu_controller.vim Outdated Show resolved Hide resolved
@Leandros
Copy link
Contributor Author

Reasonable. Will add the changes later today.

@Leandros Leandros force-pushed the master branch 2 times, most recently from 3f8c22e to ff56a9f Compare November 29, 2018 13:33
@Leandros
Copy link
Contributor Author

Incorporated your suggestions. Although, I didn't update the j/k text, since by default you'd still use j and k for navigation. The variables are documented in NERDTree.txt.

@PhilRunninger
Copy link
Member

That text needs to change. The default is j/k, but if you override them, that needs to be reflected in the text.

    echo "NERDTree Menu. Use " . g:NERDTreeMenuDown . "/" . g:NERDTreeMenuUp . "/enter and the shortcuts indicated"

@Leandros
Copy link
Contributor Author

Ahh, I didn't think of that. Makes sense.

@Leandros
Copy link
Contributor Author

Fixed.

@PhilRunninger
Copy link
Member

Excellent! Thanks for the contribution, @Leandros.

@PhilRunninger PhilRunninger merged commit c905a5d into preservim:master Nov 29, 2018
@Leandros
Copy link
Contributor Author

Thank you for NERDTree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants