Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change NERDTreeFind with args #778

Merged
merged 2 commits into from
Dec 11, 2017
Merged

change NERDTreeFind with args #778

merged 2 commits into from
Dec 11, 2017

Conversation

zhenyangze
Copy link
Contributor

No description provided.

zhenyangze and others added 2 commits December 9, 2017 16:58
@zhenyangze
change NERDTreeFind with args
12960b9
Add style improvements
2129740 
Function-local variables, instead of script-local variables, should
be used here.  In addition, "empty()" is a better choice for testing
for the absence of an argument.  Finally, the use of "else" is
removed.

The docstring is also updated to include the new argument.
lifecrisis
lifecrisis approved these changes Dec 9, 2017
View reviewed changes
Copy link
Contributor

@lifecrisis lifecrisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition. Thanks for taking care of this.

zhenyangze
zhenyangze commented Dec 10, 2017
View reviewed changes
Copy link
Contributor Author

@zhenyangze zhenyangze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed.

@PhilRunninger
Copy link
Member

👍

@PhilRunninger PhilRunninger merged commit 461ea6d into preservim:master Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifecrisis lifecrisis lifecrisis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhenyangze @PhilRunninger @lifecrisis