Use fnameescape to quote filenames for :badd. #595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you move a file in NERDTree's FS menu, and a buffer is already open with it, you're prompted to delete the old buffer and replace it with a new buffer pointing to the file's new location. This wasn't working correctly for me: because the new filename is passed to
badd
quoted with single quotes, Vim just created a new buffer pointing to a file called'/Users/zack/.../filename'
with the quotes. See the odd results of this when trying to rename a file in the nerdtree source tree:This patch uses the
fnameescape()
function to do the filename escaping, rather than just surrounding with single quotes. I've tested it and it fixes the error seen in the above screenshot.