Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd.exe /c start "" <filename> for windows default viewer support #1130

Merged
merged 5 commits into from
May 22, 2020

Conversation

jagjordi
Copy link
Contributor

@jagjordi jagjordi commented May 21, 2020

Description of Changes

Closes #1129


New Version Info

Not sure what to do here 😓

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merge, tag the merge commit, e.g. git tag -a 3.1.4 -m "v3.1.4" && git push origin --tags

Copy link
Member

@PhilRunninger PhilRunninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would better to use a more widely available command. My Windows machine has an old version of Powershell, and pwsh doesn't exist. I suggest using the start command instead. Run start /? in a cmd.exe shell for more info.

nerdtree_plugin/fs_menu.vim Outdated Show resolved Hide resolved
nerdtree_plugin/fs_menu.vim Outdated Show resolved Hide resolved
jagjordi and others added 2 commits May 22, 2020 09:10
@jagjordi
Copy link
Contributor Author

I agree, I guess eventually CMD will become obsolete in prevalence of pwsh, but thats a problem for later.

@PhilRunninger PhilRunninger changed the title Invoke-Item for windows default viewer support cmd.exe /c start "" <filename> for windows default viewer support May 22, 2020
@PhilRunninger PhilRunninger merged commit 2e9d43b into preservim:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xdg-open equivalent for windows
2 participants