If file path doesn't exist, :NERDTreeFind its parent directory instead. #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 29, 2019 11:04
This happens in the following scenario: ``` :edit path/new_file :NERDTreeFind ``` Instead of an error message about an **invalid path**, this change will now find the parent directory instead. It will not work if the new file is **path/new_folder/new_file**, and that's OK because even vim itself cannot handle both the new folder and the new file; `:w` won't create the new folder.
andys8
added a commit
to andys8/nerdtree
that referenced
this pull request
Jan 19, 2020
There was a fix in preservim#1043 which improves the behavior for non saved filenames. Those are not on disk, but also not empty. This lead to an issue preservim#1059 where actual "empty files" like created with vim-startify or stdin lead to an error. This change fixes this by adapting the order of the tests. It'll print "no file for the current buffer" for empty files. Solves preservim#1059
andys8
added a commit
to andys8/nerdtree
that referenced
this pull request
Jan 20, 2020
There was a fix in preservim#1043 which improves the behavior for non saved filenames. Those are not on disk, but also not empty. This lead to an issue preservim#1059 where actual "empty files" like created with vim-startify or stdin lead to an error. This change fixes this by adapting the order of the tests. It'll print "no file for the current buffer" for empty files. Solves preservim#1059
rhiroyuki
added a commit
to rhiroyuki/dotfiles
that referenced
this pull request
Feb 17, 2020
Remove try catch since its not necessary anymore (it doesnt raise the error and instead it opens the parent root directory). For more info: preservim/nerdtree#1043
bouk
added a commit
to bouk/nerdtree
that referenced
this pull request
Feb 20, 2020
Right now it just reveals the directory but leaves it closed. Related to preservim#1043
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens in the following scenario:
Instead of an error message about an invalid path, this change will
now find the parent directory instead. It will not work if the new file
is path/new_folder/new_file, and that's OK because even vim itself
cannot handle both the new folder and the new file;
:wwon't createthe new folder.
Description of Changes
Closes #1042
New Version Info
MAJORversion when you make incompatible API changesMINORversion when you add functionality in a backwards-compatible mannerPATCHversion when you make backwards-compatible bug fixesgit tag -a 3.1.4 -m "v3.1.4" && git push origin --tags