Make the behavior of window splits consistent #1035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes #941
This PR addresses changes requested for #941, and expands on the work started there.
Closes #327
This PR forces NERDTree to respect the user's values for the
splitright
andsplitbelow
settings, and theg:NERDTreeWinPos
variable. This changes the current behavior of the splits opened by NERDTree, so this will be a new MAJOR release - 6.0.0. The changes are as follows::NERDTree
(or:NERDTreeFocus
or:NERDTreeToggle
) was invoked. Or maybe a window command (such as10<C-W>h
) was used to jump directly to the NERDTree window. When in doubt, you can use the<C-W>p
command to jump between the previous and current windows.g:NERDTreeWinPos
variable will always be respected. This pertains to a NERDTree created wheng:NERDTreeHijackNetrw
is 1, and Vim is invoked with a directory, as invim .
. When splitting the window multiple times in this scenario, NERDTree will stay full-height on the desired side of the screen.splitright
will be be respected. When performing a vertical split (s
orgs
), the previous window will be split to the right (splitright
) or left (nosplitright
) as directed by the user's setting.splitbelow
will be be respected. When performing a horizontal split (i
orgi
), the previous window will be split above (nosplitbelow
) or below (splitbelow
) as directed by the user's setting.These changes bring consistency to the NERDTree split commands, which previously had worked differently for vertical vs horizontal splitting.
New Version Info
MAJOR
version when you make incompatible API changesMINOR
version when you add functionality in a backwards-compatible mannerPATCH
version when you make backwards-compatible bug fixesgit tag -a 3.1.4 -m "v3.1.4" && git push origin --tags