Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support react-redux v6 and React 16 context API - #581 #584

Merged
merged 10 commits into from
Dec 13, 2018
Merged

Support react-redux v6 and React 16 context API - #581 #584

merged 10 commits into from
Dec 13, 2018

Conversation

prescottprue
Copy link
Owner

@prescottprue prescottprue commented Dec 12, 2018 •
edited
Loading

Description

  • feat(core): New react context API working with HOCs (firebaseConnect, firestoreConnect withFirebase, and withFirestore) - Support React-Redux v6 #581
  • feat(core): support react-redux v6 by removing usage of context.store (used to be added by Provider from react-redux)
  • feat(core): Added ReactReduxFirebaseContext and ReduxFirestoreContext (with associated providers ReactReduxFirebaseProvider ReduxFirestoreProvider respectively)

Breaking Change: react 16.4 is now a requirement due to using new context api

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

@prescottprue prescottprue changed the title Support for stable context API - #581 Support react-redux v6 and React 16 context API - #581 Dec 12, 2018
@prescottprue prescottprue merged commit 791ec4b into v3.0.0-alpha Dec 13, 2018
@prescottprue prescottprue deleted the new-context branch December 13, 2018 01:49
@prescottprue prescottprue mentioned this pull request Dec 15, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prescottprue