chore: remove storybook, chromatic #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamKelley
force-pushed
the
wk/20231115-chore-remove-storybook-chromatic
branch
from
01961c6
to
49bbc35
Compare
WilliamKelley
changed the base branch from
wk/20231115-feat-remove-scripts
to
wk/20231115-feat-remove-spark-icons
WilliamKelley
force-pushed
the
wk/20231115-chore-remove-storybook-chromatic
branch
from
49bbc35
to
f55d834
Compare
This was referenced Nov 16, 2023
shadoath
approved these changes
Nov 20, 2023
- delete chromatic workflow - delete root storybook config: `/.storybook/`' - uninstall root storybook config deps: `npm uninstall @storybook/addon-essentials` - delete spark lib storybook config: `/libs/spark/.storybook/` - uninstall spark lib storybook deps: - explicit: `npm uninstall @storybook/addon-links storybook-addon-pseudo-states @storybook/react` - implicit: `npm uninstall @storybook/manager-webpack5 @storybook/builder-webpack5 @svgr/webpack @types/webpack webpack` - dangling: `nom uninstall @storybook/addon-storyshots` - delete nx storybook stuff - workspace spark project targets: storybook, build-storybook - uninstall nx storybook stuff: `nom uninstall @nrwl/storybook` - delete `/libs/spark/public/` (used for storybook asset storage) - delete `/libs/spark/stories/` (used for story utils)
WilliamKelley
force-pushed
the
wk/20231115-chore-remove-storybook-chromatic
branch
from
f55d834
to
f8c7361
Compare
WilliamKelley
deleted the
wk/20231115-chore-remove-storybook-chromatic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This must come before removing Spark so that the Chromatic is already removed. It's a separate concern from removing the spark stuff
/.storybook/'npm uninstall @storybook/addon-essentials/libs/spark/.storybook/npm uninstall @storybook/addon-links storybook-addon-pseudo-states @storybook/reactnpm uninstall @storybook/manager-webpack5 @storybook/builder-webpack5 @svgr/webpack @types/webpack webpacknom uninstall @storybook/addon-storyshotsnom uninstall @nrwl/storybook/libs/spark/public/(used for storybook asset storage)/libs/spark/stories/(used for story utils)