Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove spark library #714

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

WilliamKelley
Copy link
Contributor

@WilliamKelley WilliamKelley commented Nov 15, 2023

Deletes the spark library

  • delete /libs/spark/
  • delete references of "spark"
  • delete references of "components" that was implicitly for "spark"
  • delete isolated deps: npm uninstall clsx notistack @material-ui/core @material-ui/lab

@WilliamKelley WilliamKelley force-pushed the wk/20231115-feat-remove-spark-icons branch from c35ce29 to 90464f1 Compare November 15, 2023 22:57
@WilliamKelley WilliamKelley force-pushed the wk/20231115-feat-remove-spark-icons branch from 90464f1 to 14e7652 Compare November 15, 2023 23:10
@WilliamKelley WilliamKelley force-pushed the wk/20231115-feat-remove-spark branch 2 times, most recently from 04402c9 to e09fde3 Compare November 16, 2023 00:35
@WilliamKelley WilliamKelley changed the base branch from wk/20231115-feat-remove-spark-icons to wk/20231115-chore-remove-storybook-chromatic November 16, 2023 00:36
@WilliamKelley WilliamKelley reopened this Nov 16, 2023
@WilliamKelley WilliamKelley force-pushed the wk/20231115-chore-remove-storybook-chromatic branch from 49bbc35 to f55d834 Compare November 16, 2023 00:39
@WilliamKelley WilliamKelley force-pushed the wk/20231115-chore-remove-storybook-chromatic branch from f55d834 to f8c7361 Compare November 20, 2023 21:28
Base automatically changed from wk/20231115-chore-remove-storybook-chromatic to main November 20, 2023 21:29
@WilliamKelley WilliamKelley merged commit 36f789c into main Nov 20, 2023
1 check passed
@WilliamKelley WilliamKelley deleted the wk/20231115-feat-remove-spark branch November 20, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants