Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): refined global upgrade commands #948

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

chawyehsu
Copy link
Contributor

Closes #914 , closes #943

What changes

  1. Globalcli module codebase refactor, reusable definitions/functions are decoupled and moved to common.rs, doc comments are added for these definitions/functions.
  2. Address List Old and New Version in pixi global upgrade / upgrade-all #914, refined pixi global upgrade/upgrade-all ergonomic output
    pixi-global-refined
  3. Address pixi global upgrade downgrades packages to newest version in default channels #943, pixi global upgrade/upgrade-all now prevents package downgrade (by comparing versions before committing transaction) and will by default use the channel the package was installed from.
    pixi-global-refined-upgrade
  4. Globally installing package with no executables now prints a warning instead of throws out a miette error.
    before:
    pixi-global-refined-install-before
    after:
    pixi-global-refined-install-after

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you @chawyehsu! 🙏 It looks all good to me, and it works like a charm on my machine.

Small remark, I see we didn't update the list command in the documentation and you could possibly add a note about this new automatic channel selection to the documentation.

@chawyehsu
Copy link
Contributor Author

cool!

you could possibly add a note about this new automatic channel selection to the documentation.

will do to update all the doc of global commands with another PR

@ruben-arts ruben-arts merged commit 13320ba into prefix-dev:main Mar 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants