feat: Relative exclude-newer configuration#5786
feat: Relative exclude-newer configuration#5786baszalmstra merged 61 commits intoprefix-dev:mainfrom
Conversation
|
Is this also supposed to add this to the pypi dependencies? |
|
i would move this to a follow-up pr, this one will already be quite big |
hunger
left a comment
hunger
left a comment
There was a problem hiding this comment.
Didn't find any real issue:-) Good work.
pavelzw
force-pushed
the
exclude-newer-duration
branch
2 times, most recently
from
e2dede1 to
5f00270
Compare
| backend_name: &'static str, | ||
| backend_version: &'static str, |
There was a problem hiding this comment.
Lets make this backend_identifier: Option<(&'static str, &'static str)> Then on intermediate backend instantiator add a function to set these fields. Makes test code simpler.
| let (backend_name, backend_version) = self.backend_identifier.ok_or_else(|| { | ||
| miette::miette!( | ||
| "backend identifier must be set before running conda/build-v1 for the intermediate backend" | ||
| ) | ||
| })?; |
There was a problem hiding this comment.
This will break the tests no? Let just use Default for system tools if this is None too.
There was a problem hiding this comment.
SystemTools doesn't implement Default anymore. we could go with pixi-build-backend and env!("CARGO_PKG_VERSION") but not sure thats pretty?
alternatively fix upstream in rattler-build?
There was a problem hiding this comment.
Aaaah that explains why this is needed. In that case lets not make them optional indeed and just pass them directly in the constructor! Sorry I missed it if you said it earlier!
4 participants
Description
Fixes #4545
How Has This Been Tested?
AI Disclosure
Tools: codex
Checklist:
schema/model.py.