Skip to content

test: verify all manifest schema parse with common python tools#5732

Merged
ruben-arts merged 4 commits intoprefix-dev:mainfrom
bollwyvl:gh-1089-fix-empty-prop-pattern
Mar 24, 2026
Merged

test: verify all manifest schema parse with common python tools#5732
ruben-arts merged 4 commits intoprefix-dev:mainfrom
bollwyvl:gh-1089-fix-empty-prop-pattern

Conversation

@bollwyvl
Copy link
Copy Markdown
Contributor

@bollwyvl bollwyvl commented Mar 19, 2026

Description

Over on #1089, it was noted that the generated schema failed to parse with python-fastjsonschema. This is in particular a problem for pyproject.toml, as:

We can't use anything besides fastjsonschema, because it renders standalone .py files with no dependencies on any package, and those get vendored into setuptools. (Not for arbitrary tools, but only for setuptools and general schema) — @henryiii

References:

Changes:

  • pixi.toml#/feature/schema/dependencies
    • bump pydantic
    • add/restore widely-used Python schema validator libraries
      • jsonschema
      • python-fastjsonschema
  • schema
    • test_manifest.py
      • verify each generated schema can be parsed as a validator by each of the above libraries (in addition to jsonschema-rs)
    • model.py
      • base TaskName off NonEmptyString to force valid propertyNames in a number of places
        • appears to be a bug in pydantic where the pattern is discarded in propertyNames, but minLength works

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py.

@bollwyvl bollwyvl changed the title verify all manifest schema parse with common python tools test: verify all manifest schema parse with common python tools Mar 19, 2026
@bollwyvl bollwyvl marked this pull request as ready for review March 19, 2026 21:08
Copy link
Copy Markdown
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bollwyvl !

@ruben-arts ruben-arts merged commit 6739a13 into prefix-dev:main Mar 24, 2026
42 checks passed
@bollwyvl bollwyvl deleted the gh-1089-fix-empty-prop-pattern branch March 24, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants