Skip to content

feat: report installation progress to terminal#5634

Merged
baszalmstra merged 1 commit intoprefix-dev:mainfrom
hunger:push-lplxkwlmspop
Mar 17, 2026
Merged

feat: report installation progress to terminal#5634
baszalmstra merged 1 commit intoprefix-dev:mainfrom
hunger:push-lplxkwlmspop

Conversation

@hunger
Copy link
Copy Markdown
Contributor

@hunger hunger commented Mar 10, 2026

Description

Report installation progress to terminal so it can draw a progress bar or whatever the terminal is configured to do with those reports.

How Has This Been Tested?

By running it on Linux in a VTE-based terminal. It should also work in iterm2 and the new windows terminal, but I did not test that.

Terminals that do not support OSC9 escape sequences should just ignore this. That works fine for me when running pixi in zellij.

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: Claude

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py.

@baszalmstra
Copy link
Copy Markdown
Contributor

Does this also work with --no-progress?

@Hofer-Julian
Copy link
Copy Markdown
Contributor

Does this also work with --no-progress?

At the moment, it still shows the progress emoji if --no-progress is given.
@baszalmstra says it should be hidden in that case

... so it can draw a progress bar or whatever the terminal
is configured to do with those reports.
@hunger hunger force-pushed the push-lplxkwlmspop branch from cf365fb to d31e6de Compare March 10, 2026 08:51
@hunger
Copy link
Copy Markdown
Contributor Author

hunger commented Mar 10, 2026

The latest version I pushed only prints out the escape codes if the progress bar is visible (== not hidden).

It works with --no-progress now.

@baszalmstra baszalmstra changed the title feat: Report installation progress to terminal feat: report installation progress to terminal Mar 17, 2026
@baszalmstra baszalmstra merged commit eafc244 into prefix-dev:main Mar 17, 2026
70 of 71 checks passed
@hunger hunger deleted the push-lplxkwlmspop branch March 17, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants