refactor: BREAKING: make name optional#4410
Merged
ruben-arts merged 9 commits intoprefix-dev:mainfrom Aug 26, 2025
Merged
Conversation
This was referenced Aug 26, 2025
ruben-arts
reviewed
Aug 26, 2025
| self.index_json | ||
| .as_ref() | ||
| .map(|j| j.name.clone()) | ||
| .unwrap_or_else(|| { |
Contributor
There was a problem hiding this comment.
Not sure what to do here, we could also make this an unreachable as that would be really weird. But rattler-build currently already errors.
baszalmstra
commented
Aug 26, 2025
baszalmstra
commented
Aug 26, 2025
...pixi_manifest__discovery__test__explicit_workspace_discoverer@split_package_bad_package.snap
Outdated
Show resolved
Hide resolved
ruben-arts
reviewed
Aug 26, 2025
ruben-arts
approved these changes
Aug 26, 2025
Contributor
ruben-arts
left a comment
ruben-arts
left a comment
There was a problem hiding this comment.
Self approve after discussion with @baszalmstra
ruben-arts
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This was required:
With the current changes in this PR you can make a project build by pixi by only adding the following:
BREAKING:
This is a breaking change for the lockfiles, as the
namein the source hash of the lockfile. Which broke thehashof the lockfiles. This will only be breaking for anyone using thepreview = ["pixi-build"]!Blocks: