Skip to content

refactor: Move global into new pixi_global crate#4388

Merged
Hofer-Julian merged 1 commit intoprefix-dev:mainfrom
haecker-felix:pixi_global
Aug 20, 2025
Merged

refactor: Move global into new pixi_global crate#4388
Hofer-Julian merged 1 commit intoprefix-dev:mainfrom
haecker-felix:pixi_global

Conversation

@haecker-felix
Copy link
Collaborator

@haecker-felix haecker-felix commented Aug 19, 2025

Moves the global module into a new pixi_global crate.

Had to move list::{PackageToOutput, print_package_table} and repodata::Repodata into the shared pixi_utils, as both pixi and pixi_core depend on these.

I'm not entirely sure if pixi_utils is the correct crate for that - but it would work finely, given that this stuff doesn't depend on any other pixi_* crate.

@haecker-felix haecker-felix added the refactor Specifies PR or Issue is related to a refactor label Aug 19, 2025
@haecker-felix haecker-felix force-pushed the pixi_global branch 2 times, most recently from 761ac27 to e2e6691 Compare August 19, 2025 06:52
Copy link
Contributor

@tdejager tdejager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm unsure of the addition of these files to pixi_utils, probably pixi_utils is not that good of crate to begin with. However, we could just make a note to analyze when we have split more how to split up that crate. I know uv has a uv-traits for example for shared traits like the Repodata.

@Hofer-Julian
Copy link
Contributor

CI is failing on Windows :)

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. As soon as CI is green, we can merge this from my side

@haecker-felix
Copy link
Collaborator Author

CI is green now :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of moving these files to pixi_utils (which is arguably the worst crate) I think we should keep them in core and let pixi_global depend on core.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all, yeah, that makes more sense. I moved them back into pixi_core 👍

@haecker-felix haecker-felix force-pushed the pixi_global branch 4 times, most recently from f7f1fd1 to 2c89100 Compare August 19, 2025 14:47
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@Hofer-Julian Hofer-Julian merged commit dba9ef5 into prefix-dev:main Aug 20, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Specifies PR or Issue is related to a refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants