refactor: Move global into new pixi_global crate#4388
refactor: Move global into new pixi_global crate#4388Hofer-Julian merged 1 commit intoprefix-dev:mainfrom
Conversation
761ac27 to
e2e6691
Compare
tdejager
left a comment
There was a problem hiding this comment.
This looks good to me. I'm unsure of the addition of these files to pixi_utils, probably pixi_utils is not that good of crate to begin with. However, we could just make a note to analyze when we have split more how to split up that crate. I know uv has a uv-traits for example for shared traits like the Repodata.
e2e6691 to
847911b
Compare
|
CI is failing on Windows :) |
Hofer-Julian
left a comment
There was a problem hiding this comment.
Changes look good to me. As soon as CI is green, we can merge this from my side
847911b to
77e9677
Compare
|
CI is green now :) |
There was a problem hiding this comment.
Instead of moving these files to pixi_utils (which is arguably the worst crate) I think we should keep them in core and let pixi_global depend on core.
There was a problem hiding this comment.
After all, yeah, that makes more sense. I moved them back into pixi_core 👍
f7f1fd1 to
2c89100
Compare
2c89100 to
299e7d6
Compare
Moves the
globalmodule into a newpixi_globalcrate.Had to movelist::{PackageToOutput, print_package_table}andrepodata::Repodatainto the sharedpixi_utils, as bothpixiandpixi_coredepend on these.I'm not entirely sure ifpixi_utilsis the correct crate for that - but it would work finely, given that this stuff doesn't depend on any otherpixi_*crate.