feat: pass run dependencies and run exports#4373
Merged
ruben-arts merged 5 commits intoprefix-dev:mainfrom Aug 18, 2025
Merged
Conversation
baszalmstra
commented
Aug 18, 2025
| #[serde(rename_all = "camelCase")] | ||
| pub struct CondaBuildV1Dependency { | ||
| #[serde_as(as = "DisplayFromStr")] | ||
| pub spec: MatchSpec, |
Contributor
Author
There was a problem hiding this comment.
I opted to return MatchSpec here instead of something that could also be a source record because that is what is eventually stored in the index.json file.
ruben-arts
approved these changes
Aug 18, 2025
Contributor
ruben-arts
left a comment
ruben-arts
left a comment
There was a problem hiding this comment.
I've tested:
- [x]: run dependencies
- [x]: weak exports
- [x]: run constraints
- [x]: with and without matchspecs
Can't break it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the build protocol to pass information about:
This is needed in the backends to correctly fill in the
index.jsoninside the constructed package.This PR should not break any existing CIs. Backends should just silently ignore these fields if they receive it. Another PR in the backends is required to make sure that these fields are picked up properly.