fix: preserve decoration when inserting dependency#4370
Merged
ruben-arts merged 3 commits intoprefix-dev:mainfrom Aug 18, 2025
Conversation
baszalmstra
commented
Aug 16, 2025
| exclude-newer = "2025-05-19" | ||
|
|
||
| [pypi-dependencies] | ||
| click = { version = ">=8.2.0, <9", index = "https://pypi.tuna.tsinghua.edu.cn/simple" } |
Contributor
Author
There was a problem hiding this comment.
This is immediately an interesting case that was previously "broken". There are whitespaces in front of all the keys. These were removed previously. The new implementation retains this.
ruben-arts
approved these changes
Aug 18, 2025
Contributor
ruben-arts
left a comment
ruben-arts
left a comment
There was a problem hiding this comment.
Great stuff! Can't break it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4267.
Fixes an issue where the decorations (comments, newlines, etc) were not retained when pixi re-adds a dependency to the manifest file. This happens when you run
pixi upgradeorpixi addwith an existing dependency.