refactor: Move much as possible into new pixi_core crate#4328
Closed
haecker-felix wants to merge 4 commits intoprefix-dev:mainfrom
Closed
refactor: Move much as possible into new pixi_core crate#4328haecker-felix wants to merge 4 commits intoprefix-dev:mainfrom
haecker-felix wants to merge 4 commits intoprefix-dev:mainfrom
Conversation
lucascolley
added
refactor
haecker-felix
force-pushed
the
pixi_core
branch
3 times, most recently
from
942139d to
d88a805
Compare
Contributor
Hofer-Julian
left a comment
Hofer-Julian
left a comment
There was a problem hiding this comment.
Only minimal comments, then we can merge it!
haecker-felix
force-pushed
the
pixi_core
branch
from
d88a805 to
e7d7fba
Compare
Contributor
|
Close in favor of #4337 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to use this as a starting point and to split
pixi_coreinto more crates in following PRs (eg.pixi_environmentetc).As a next step we likely need to introduce some
pixi_core_typesor similar (inspired byuv_types), as the modules are depending on each other and we very likely would get cyclic dependencie (see #4302 (comment))Replaces: #4302