Skip to content

fix(add): pixi-build preview-mode check#4224

Merged
ruben-arts merged 4 commits intoprefix-dev:mainfrom
remimimimimi:fix/preview-mode-check
Jul 30, 2025
Merged

fix(add): pixi-build preview-mode check#4224
ruben-arts merged 4 commits intoprefix-dev:mainfrom
remimimimimi:fix/preview-mode-check

Conversation

@remimimimimi
Copy link
Contributor

No description provided.

@remimimimimi remimimimimi requested a review from ruben-arts July 28, 2025 13:55
@lucascolley lucascolley changed the title fix(pixi add): pixi-build preview-mode check fix(add): pixi-build preview-mode check Jul 28, 2025
@remimimimimi remimimimimi force-pushed the fix/preview-mode-check branch from fc8f918 to 9630455 Compare July 29, 2025 08:05
@remimimimimi remimimimimi requested a review from nichmor July 29, 2025 08:16
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should immediately know what to do based on the error. For the rest this seems fine to me.
Could you sync the error with the error given by the solver when it was not defined?

Co-authored-by: Ruben Arts <ruben@prefix.dev>
@lucascolley lucascolley added bug Something isn't working area:add Related to pixi add labels Jul 29, 2025
@remimimimimi remimimimimi force-pushed the fix/preview-mode-check branch from fcb61c6 to 8158df8 Compare July 29, 2025 11:13
@remimimimimi remimimimimi requested a review from ruben-arts July 29, 2025 11:36
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ruben-arts ruben-arts enabled auto-merge (squash) July 30, 2025 10:54
@ruben-arts ruben-arts merged commit 7530911 into prefix-dev:main Jul 30, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:add Related to pixi add bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants