feat: add new configuration options for concurrency and experimental features#4223
Merged
ruben-arts merged 11 commits intoprefix-dev:mainfrom Jul 30, 2025
Merged
feat: add new configuration options for concurrency and experimental features#4223ruben-arts merged 11 commits intoprefix-dev:mainfrom
ruben-arts merged 11 commits intoprefix-dev:mainfrom
Conversation
Contributor
|
Thank you adding this is great, we've been lacking on implementation here! It's currently missing in the function that reads the cli into configuration. When that is added it is going to be great! |
ruben-arts
requested changes
Jul 29, 2025
Contributor
ruben-arts
left a comment
ruben-arts
left a comment
There was a problem hiding this comment.
Since we're now adding this to the CLI we have to start testing it in the integration tests, to avoid future breaking changes.
Could you add those aswell?
| @@ -120,25 +120,45 @@ pub fn get_cache_dir() -> miette::Result<PathBuf> { | |||
| } | |||
| #[derive(Parser, Debug, Default, Clone)] | |||
| pub struct ConfigCli { | |||
Contributor
There was a problem hiding this comment.
I took the liberty to order this alphabetically 😄
lucascolley
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will add the missing keys
concurrencyconcurrency.downloadsconcurrency.solvesexperimentalrun-post-link-scriptsand new unit tests to test our keys inget_keysi think the concurrency refactor (to be honest no idea who did it in which commit, i simply figured that out from the changes i saw in my hash validation pr when i was updating with merge conflicts) we missed this part since we were still usingmax-concurrent-solves