feat: prevent pixi init to be executed in parent of pixi home directory

[ytausch]

Closes #4166.

@lucascolley I implemented the feature. Can you guide me on how your testing strategy imposes tests for this change?

[lucascolley]

nice! Could you add a test next to

pixi/tests/integration_python/test_main_cli.py

Lines 391 to 404 in 1a4df75

	def test_pixi_init_non_existing_dir(pixi: Path, tmp_pixi_workspace: Path) -> None:
	# Specify project dir
	project_dir = tmp_pixi_workspace / "project_dir"
	# Create a new project
	verify_cli_command([pixi, "init", project_dir], ExitCode.SUCCESS)
	# Verify that the manifest file is created
	manifest_path = project_dir / "pixi.toml"
	assert manifest_path.exists()
	# Verify that the manifest file contains expected content
	manifest_content = manifest_path.read_text()
	assert "[workspace]" in manifest_content

? I think you can use verify_cli_command to attempt the init.

pixi/tests/integration_python/common.py

Lines 49 to 59 in 1a4df75

	def verify_cli_command(
	command: list[Path | str],
	expected_exit_code: ExitCode = ExitCode.SUCCESS,
	stdout_contains: str | list[str] | None = None,
	stdout_excludes: str | list[str] | None = None,
	stderr_contains: str | list[str] | None = None,
	stderr_excludes: str | list[str] | None = None,
	env: dict[str, str] | None = None,
	cwd: str | Path | None = None,
	reset_env: bool = False,
	) -> Output:

Use the env argument to set PIXI_HOME, pass ExitCode.FAILURE, and pass the expected error message to stderr_contains.

[ytausch]

Thank you! I added the test.

[lucascolley]

thanks!

[lucascolley]

maybe https://doc.rust-lang.org/std/fs/fn.canonicalize.html#platform-specific-behavior is causing the windows failure?

[ytausch]

Fixed!

[lucascolley]

LGTM!

[lucascolley]

@Hofer-Julian can you press the green button :) ?

[Hofer-Julian]

@Hofer-Julian can you press the green button :) ?

Happy to, but you should be able to do that as well, right?

[lucascolley]

I can now, thanks @ytausch !