Skip to content

fix: warn about no pinning strategy for unused features #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucascolley merged 1 commit into from
Aug 23, 2025
Merged

fix: warn about no pinning strategy for unused features #4065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/pixi_manifest/src/toml/manifest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ impl TomlManifest {

warnings.push(Warning::from(
GenericError::new(format!(
"The feature '{}' is defined but not used in any environment",
"The feature '{}' is defined but not used in any environment. Dependencies of unused features are not resolved or checked, and use wildcard (*) version specifiers by default, disregarding any set `pinning-strategy`",
feature_name
))
.with_opt_span(span)
Expand Down
3 changes: 2 additions & 1 deletion ...l/snapshots/pixi_manifest__toml__feature__test__mismatching_excluded_target_selector.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ expression: "expect_parse_warnings(r#\"\n [workspace]\n name = \"t
╰────
help: Add one of 'osx-64', 'osx-arm64' to the supported platforms, using `pixi project platform add osx-64`

⚠ The feature 'foo' is defined but not used in any environment
⚠ The feature 'foo' is defined but not used in any environment. Dependencies of unused features are not resolved or checked, and use wildcard (*) version specifiers by default, disregarding any
│ set `pinning-strategy`
╭─[pixi.toml:7:18]
6 │
7 │ [feature.foo]
Expand Down
3 changes: 2 additions & 1 deletion ...t/src/toml/snapshots/pixi_manifest__toml__feature__test__mismatching_target_selector.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ expression: "expect_parse_warnings(r#\"\n [workspace]\n name = \"t
╰────
help: Add osx-64 to the supported platforms, using `pixi project platform add osx-64`

⚠ The feature 'foo' is defined but not used in any environment
⚠ The feature 'foo' is defined but not used in any environment. Dependencies of unused features are not resolved or checked, and use wildcard (*) version specifiers by default, disregarding any
│ set `pinning-strategy`
╭─[pixi.toml:7:18]
6 │
7 │ [feature.foo.target.osx-64.dependencies]
Expand Down
6 changes: 4 additions & 2 deletions ...ixi_manifest/src/toml/snapshots/pixi_manifest__toml__manifest__test__unused_features.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
source: crates/pixi_manifest/src/toml/manifest.rs
expression: "expect_parse_warnings(r#\"\n [workspace]\n name = \"foo\"\n channels = []\n platforms = ['osx-64']\n\n [feature.foobar.dependencies]\n\n [feature.generic.target.osx.dependencies]\n \"#,)"
---
⚠ The feature 'foobar' is defined but not used in any environment
⚠ The feature 'foobar' is defined but not used in any environment. Dependencies of unused features are not resolved or checked, and use wildcard (*) version specifiers by default, disregarding any
│ set `pinning-strategy`
╭─[pixi.toml:7:18]
6 │
7 │ [feature.foobar.dependencies]
Expand All @@ -11,7 +12,8 @@ expression: "expect_parse_warnings(r#\"\n [workspace]\n name = \"f
╰────
help: Remove the feature from the manifest or add it to an environment

⚠ The feature 'generic' is defined but not used in any environment
⚠ The feature 'generic' is defined but not used in any environment. Dependencies of unused features are not resolved or checked, and use wildcard (*) version specifiers by default, disregarding
│ any set `pinning-strategy`
╭─[pixi.toml:9:18]
8 │
9 │ [feature.generic.target.osx.dependencies]
Expand Down
Loading