-
Notifications
You must be signed in to change notification settings - Fork 537
feat: per platform extra options for pixi build configuration #4036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hofer-Julian
merged 9 commits into
prefix-dev:main
from
Hofer-Julian:feature/pix-642-per-platform-extra-options-for-cmake
Jul 29, 2025
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3159f1b
Address comments
Hofer-Julian a6a6d79
Merge branch 'main' into feature/pix-642-per-platform-extra-options-f…
Hofer-Julian 8390885
Update schema
Hofer-Julian 21444bf
Merge branch 'main' into feature/pix-642-per-platform-extra-options-f…
Hofer-Julian bb8339c
Hook up more things
Hofer-Julian cf93050
Merge branch 'main' into feature/pix-642-per-platform-extra-options-f…
Hofer-Julian 7ad3e8d
Update snapshots
Hofer-Julian 450cf5c
typos [skip ci]
lucascolley 5b1884d
Merge branch 'main' into feature/pix-642-per-platform-extra-options-f…
lucascolley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,3 +18,4 @@ init-params: | |
| manifest-path: recipe.yaml | ||
| project-model: ~ | ||
| configuration: ~ | ||
| target-configuration: ~ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,3 +34,4 @@ init-params: | |
| runDependencies: {} | ||
| targets: {} | ||
| configuration: ~ | ||
| target-configuration: ~ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,3 +34,4 @@ init-params: | |
| runDependencies: {} | ||
| targets: {} | ||
| configuration: ~ | ||
| target-configuration: ~ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,3 +19,4 @@ init-params: | |
| manifest-path: recipe/recipe.yml | ||
| project-model: ~ | ||
| configuration: ~ | ||
| target-configuration: ~ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,3 +19,4 @@ init-params: | |
| manifest-path: recipe.yaml | ||
| project-model: ~ | ||
| configuration: ~ | ||
| target-configuration: ~ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,3 +19,4 @@ init-params: | |
| manifest-path: recipe.yml | ||
| project-model: ~ | ||
| configuration: ~ | ||
| target-configuration: ~ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,3 +34,4 @@ init-params: | |
| runDependencies: {} | ||
| targets: {} | ||
| configuration: ~ | ||
| target-configuration: ~ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| mod project_model; | ||
|
|
||
| pub use project_model::{compute_project_model_hash, to_project_model_v1}; | ||
| pub use project_model::{compute_project_model_hash, to_project_model_v1, to_target_selector_v1}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| use toml_span::{DeserError, Value, de_helpers::TableHelper}; | ||
|
|
||
| use crate::toml::build_system::convert_toml_to_serde; | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct TomlPackageBuildTarget { | ||
| pub configuration: Option<serde_value::Value>, | ||
| } | ||
|
|
||
| impl<'de> toml_span::Deserialize<'de> for TomlPackageBuildTarget { | ||
| fn deserialize(value: &mut Value<'de>) -> Result<Self, DeserError> { | ||
| let mut th = TableHelper::new(value)?; | ||
| let configuration = th | ||
| .take("configuration") | ||
| .map(|(_, mut value)| convert_toml_to_serde(&mut value)) | ||
| .transpose()?; | ||
|
|
||
| th.finalize(None)?; | ||
| Ok(TomlPackageBuildTarget { configuration }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| mod build_system; | ||
| mod build_target; | ||
| mod channel; | ||
| mod document; | ||
| mod environment; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,4 +84,5 @@ TomlPackageBuild { | |
| }, | ||
| ), | ||
| ), | ||
| target: {}, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.