fix: for local directory satisfiability#3631
Merged
baszalmstra merged 5 commits intoprefix-dev:mainfrom Apr 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with local directory satisfiability by normalizing relative paths before comparing them, and adds a test to validate the fix.
- Updated error messaging and path comparisons in pypi_satifisfies_requirement.
- Added a new test file to cover local-wheel scenarios.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/data/satisfiability/local-wheel/pixi.toml | Added test configuration for local wheel paths. |
| src/lock_file/satisfiability.rs | Updated path normalization and error message for LockedPyPIPathMismatch. |
Comments suppressed due to low confidence (1)
src/lock_file/satisfiability.rs:918
- [nitpick] Consider renaming the variable 'locked_path' (after joining with 'project_root') to a more descriptive name (e.g., 'resolved_locked_path') to avoid confusion with the original 'locked_path'.
let locked_path = project_root.join(locked_path.to_path());
baszalmstra
approved these changes
Apr 17, 2025
wolfv
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a pixi.toml like:
Keeps invalidating with the message:
This adds a test to satisfiability and fixes by normalizing in that case.