fix: don't keep reinstalling local pypi archives#3618
Merged
tdejager merged 5 commits intoprefix-dev:mainfrom Apr 17, 2025
Merged
fix: don't keep reinstalling local pypi archives#3618tdejager merged 5 commits intoprefix-dev:mainfrom
tdejager merged 5 commits intoprefix-dev:mainfrom
Conversation
baszalmstra
approved these changes
Apr 15, 2025
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a pypi local archive things keep reinstalling.
The above kept happening. This PR fixes that behavior.
This pull request includes several changes to the
src/install_pypi/plan/test/harness.rs,src/install_pypi/plan/test/mod.rs, andsrc/install_pypi/plan/validation.rsfiles to improve the handling of PyPI package installations and their validation.The most important changes are summarized below:
Improvements to PyPI package data handling:
directoryfunction topathinimpl PyPIPackageDataBuilderto better reflect its purpose.add_local_wheeltoRequiredPackagesfor adding local wheel files.Enhancements to test harness:
install_planner_with_lock_dirfunction to create anInstallPlannerwith a specified lock directory. This will help for relative path testing.fake_wheelfunction to create a fake wheel file for testing purposes.Validation improvements:
NeedsReinstallErrorto include a new variantFreshnessErrorfor errors encountered while checking freshness.need_reinstallfunction to handle relative paths and check the freshness of URLs more robustly. [1] [2]