fix: shell-hook --no-completion#3553
Merged
Hofer-Julian merged 2 commits intoprefix-dev:mainfrom Apr 9, 2025
Merged
Conversation
Fixes prefix-dev#3549 Merging of config was faulty for `pixi shell-hook`, this PR fixes that. Unfortunately, this also includes a breaking change. Seems like we missed that `Option<bool>` leads to a bit weird CLI which requires users to type `--no-completion true`, which doesn't make a lot of sense. Changing to `bool`, changes this to `--no-completion` Since this is breaking anyway, I also adapt `--no-completion` to `--no-completions`.
2 tasks
wolfv
approved these changes
Apr 9, 2025
wolfv
reviewed
Apr 9, 2025
| number: 1 | ||
| script: | ||
| # ZSH completions | ||
| - mkdir -p $PREFIX/share/zsh/site-functions |
Member
There was a problem hiding this comment.
I am not sure mkdir -p works on Windows.
Contributor
Author
There was a problem hiding this comment.
As is, if one wants to update our test channels on windows, they will have to run it with bash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3549
Merging of config was faulty for
pixi shell-hook, this PR fixes that. Unfortunately, this also includes a breaking change. Seems like we missed thatOption<bool>leads to a CLI which requires users to type--no-completion true, which doesn't make a lot of sense. Changing tobool, changes this to--no-completionSince this is breaking anyway, I also adapt--no-completionto--no-completions.