Skip to content

feat: short circuit composition support#3540

Merged
Hofer-Julian merged 25 commits intomainfrom
short_circuit
Apr 9, 2025
Merged

feat: short circuit composition support#3540
Hofer-Julian merged 25 commits intomainfrom
short_circuit

Conversation

@prsabahrami
Copy link
Copy Markdown
Contributor

This automatically turns a task into an alias in case the below format is provided:

[tasks.test]
cmd = "pytest tests/{{ test-type }}"
args = ["test-type"]

[tasks]
test-all = [{ task = "test", args = ["all"] }]
# Equivalent to: test-all = { depends-on = [{task = "test", args = ["all"] }]}

@prsabahrami prsabahrami changed the title feat: wip: short circuit composition support feat: short circuit composition support Apr 8, 2025
@prsabahrami prsabahrami marked this pull request as ready for review April 8, 2025 14:07
@prsabahrami prsabahrami requested a review from Hofer-Julian April 8, 2025 15:12
Copy link
Copy Markdown
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

[workspace]
name = "test"
channels = []
platforms = ["linux-64", "win-64", "osx-64"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add osx-arm64

"""
manifest.write_text(toml)

verify_cli_command([pixi, "task", "alias", "dummy-a", "dummy-b", "dummy-c", "--manifest-path", manifest])
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also test pixi task alias --platform

Copy link
Copy Markdown
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work Parsa 🥳🥳🥳

@Hofer-Julian Hofer-Julian enabled auto-merge (squash) April 9, 2025 14:09
@Hofer-Julian Hofer-Julian merged commit 58b800b into main Apr 9, 2025
36 checks passed
@Hofer-Julian Hofer-Julian deleted the short_circuit branch April 9, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants