Skip to content

test: build backend missing executable#3527

Merged
Hofer-Julian merged 4 commits intoprefix-dev:mainfrom
baszalmstra:test/empty-build-backend
Apr 11, 2025
Merged

test: build backend missing executable#3527
Hofer-Julian merged 4 commits intoprefix-dev:mainfrom
baszalmstra:test/empty-build-backend

Conversation

@baszalmstra
Copy link
Copy Markdown
Contributor

Adds a test to verify the error that occurs when a build backend is used that does not expose the expected executable.

@baszalmstra baszalmstra requested a review from Hofer-Julian April 7, 2025 12:23
@Hofer-Julian
Copy link
Copy Markdown
Contributor

Can you update the lock file @baszalmstra?

Copy link
Copy Markdown
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, forgot to send off the review 🙈

pixi.toml Outdated
Comment on lines +197 to +198
[environments.recipes]
features = ["recipes"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an inline table a few lines later like we do for the other environments?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it like this because I like that everything related to that environment is contained together instead of being spread out over the file. Would be happy to revert if you think its unclearer.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind in general, but I prefer to keep it consistent. As is we define all environments together at the end.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the definition to the environments table.

@Hofer-Julian Hofer-Julian enabled auto-merge (squash) April 11, 2025 09:40
@Hofer-Julian Hofer-Julian merged commit 18e35fc into prefix-dev:main Apr 11, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants