feat: make workspace name optional#3526
Merged
Hofer-Julian merged 3 commits intoprefix-dev:mainfrom Apr 7, 2025
Merged
Conversation
trim21
reviewed
Apr 7, 2025
| @@ -36,14 +36,6 @@ The minimally required information in the `project` table is: | |||
| --8<-- "docs/source_files/pixi_tomls/simple_pixi.toml:project" | |||
| ``` | |||
|
|
|||
Contributor
There was a problem hiding this comment.
project.name also become optional?
Contributor
Author
There was a problem hiding this comment.
project is an alias for workspace these days. But since the docs still reference "project" I changed the text.
Contributor
There was a problem hiding this comment.
so now project is splited in to workspace and package?
Contributor
There was a problem hiding this comment.
project == workspace
package is a new thing for pixi build :)
baszalmstra
force-pushed
the
refactor/make_name_optional
branch
from
941099b to
8b0cfe3
Compare
Hofer-Julian
approved these changes
Apr 7, 2025
Contributor
Hofer-Julian
left a comment
Hofer-Julian
left a comment
There was a problem hiding this comment.
Great work, thanks Bas!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the workspace name optional and instead allows deriving the name from the location of were the workspace is stored. E.g. if the workspace is stored under
/foo/bar/pixi.tomlthe name of the workspace will default tobar. If the workspace is stored under/pixi.tomlthe workspace will have the fallback name "workspace".The workspace name is used only to provide context to the user so I think this behavior is appropriate. This is different from the package name, which is also stored in the lock-file.
Tests
I added 3 tests to verify the behavior.
Fixes #3431
Closes #3514