docs: Migrate ros2.md example to use robostack-humble channel#3520
Merged
Hofer-Julian merged 5 commits intoprefix-dev:mainfrom Apr 11, 2025
Merged
docs: Migrate ros2.md example to use robostack-humble channel#3520Hofer-Julian merged 5 commits intoprefix-dev:mainfrom
Hofer-Julian merged 5 commits intoprefix-dev:mainfrom
Conversation
Contributor
|
Thanks for the PR @traversaro. Since I am not that informed about the ROS world, I'll leave the review up to @wolfv :) |
baszalmstra
reviewed
Apr 10, 2025
Contributor
baszalmstra
left a comment
baszalmstra
left a comment
There was a problem hiding this comment.
Looks good to me!
I do think we should use https://prefix.dev/conda-forge and https://prefix.dev/robostack-humble.
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Contributor
|
I took the liberty of replacing all channels with prefix channels in the examples. |
baszalmstra
approved these changes
Apr 11, 2025
Contributor
Author
Thanks! Yes I wanted to do that but the backlog of the end of the week was a bit crowded, thanks for handling that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the RoboStack side in RoboStack/robostack.github.io#73 we migrated our documentation from using the legacy
robostack-stagingchannel (used by Noetic and Humble) to the more clear distro-specific channelsrobostack-noetic,robostack-humbleandrobostack-jazzy(used by Noetic, Humble and Jazzy).This PR updates the ROS 2 tutorial to also use
robostack-humblefor consistency.There are other parts of the pixi repo that still useThe other tutorials were updated in 6baee05 .robostack-staging, but I plan to update those in different PRs.